IN operator now returns false if string indexer is used to search for property and returns null#105
Merged
FlorianRappl merged 1 commit intoAngleSharp:develfrom Apr 14, 2025
Merged
Conversation
… property and returns null
FlorianRappl
approved these changes
Apr 14, 2025
Contributor
FlorianRappl
left a comment
There was a problem hiding this comment.
LGTM - thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Fixes #104.
When IN operator is used to search for property in an object and that object doesn't have the property, but has string indexer, then the indexer is used to look for property. Before fix, even if indexer returned null, i.e. "doesn't exist", IN returned true.
A few additional tests for IN operator were added as well, just to be sure if this change didn't break anything.